pass by value in basic traits

1 files changed, 14 insertions, 14 deletions

diff --git a/src/basic_traits.c b/src/basic_traits.c
index e3e6b1b..d46de15 100644
--- a/src/basic_traits.c
+++ b/src/basic_traits.c
@@ -5,16 +5,16 @@
 #include "mmhash.h"
 
 #define BASIC_TRAITS_IMPL(T) \
-    bool T##_eq(T* lhs, T* rhs) { \
-        return *lhs == *rhs; \
+    bool T##_eq(T lhs, T rhs) { \
+        return lhs == rhs; \
     } \
-    int T##_cmp(T* lhs, T* rhs) { \
-        if (*lhs == *rhs) return 0; \
-        if (*lhs < *rhs) return -1; \
+    int T##_cmp(T lhs, T rhs) { \
+        if (lhs == rhs) return 0; \
+        if (lhs < rhs) return -1; \
         return 1; \
     } \
-    uint64_t T##_hash(T* x) { \
-        return mmhash(x, sizeof(T), 0); \
+    uint64_t T##_hash(T x) { \
+        return mmhash(&x, sizeof(T), 0); \
     }
 
 BASIC_TRAITS_IMPL(Char);
@@ -27,17 +27,17 @@ BASIC_TRAITS_IMPL(Double);
 BASIC_TRAITS_IMPL(Float);
 BASIC_TRAITS_IMPL(VoidPtr);
 
-bool String_eq(String* lhs, String *rhs) {
-    return strcmp(*lhs, *rhs) == 0;
+bool String_eq(String lhs, String rhs) {
+    return strcmp(lhs, rhs) == 0;
 }
 
-int String_cmp(String* lhs, String *rhs) {
-    return strcmp(*lhs, *rhs);
+int String_cmp(String lhs, String rhs) {
+    return strcmp(lhs, rhs);
 }
 
-ULong String_hash(String *x) {
-    size_t len = strlen(*x);
-    return mmhash(*x, len, 0);
+ULong String_hash(String x) {
+    size_t len = strlen(x);
+    return mmhash(x, len, 0);
 }